This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update Framework and Lisk-chain to have updated account - Closes #4924 #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
4924-update_account_properties
branch
from
e941c91
to
1e0dc75
Compare
pablitovicente
approved these changes
Mar 20, 2020
nazarhussain
suggested changes
Mar 20, 2020
| ALTER TABLE "mem_accounts" ADD COLUMN IF NOT EXISTS "totalVotesReceived" BIGINT NOT NULL DEFAULT 0; | ||
| ALTER TABLE "mem_accounts" ADD COLUMN IF NOT EXISTS "delegate" jsonb; | ||
| ALTER TABLE "mem_accounts" ADD COLUMN IF NOT EXISTS "votes" jsonb; | ||
| ALTER TABLE "mem_accounts" ADD COLUMN IF NOT EXISTS "unlocking" jsonb; |
There was a problem hiding this comment.
I prefer to have atomic migration for each change, not so strict, but see if you can split these to multiple migrations.
There was a problem hiding this comment.
wouldn't it better if all related changes are in the one file? what's the benefit of splitting to each file?
...work/src/application/storage/migrations/node/20200316000000_add_new_dpos_to_mem_accounts.sql
Show resolved
Hide resolved
Co-Authored-By: Nazar Hussain <[email protected]>
Co-Authored-By: Nazar Hussain <[email protected]>
Co-Authored-By: Nazar Hussain <[email protected]>
nazarhussain
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4924
How was it solved?
Updated all the required fields for the consensus related changes
How was it tested?