This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Reject unnecessary messages - Closes #4424 #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… development * 'development' of https://github.com/LiskHQ/lisk-sdk: P2P test add peerBook check at connection create and cleanup Remove unnecessary .only() Update describe() format in connection_create.ts P2P introduce Functional testing P2P introduce Functional testing
diego-G
suggested changes
Oct 24, 2019
diego-G
suggested changes
Oct 24, 2019
ishantiw
force-pushed
the
4424-reject_unnecessary_messages
branch
from
878a621
to
c42c4dc
Compare
diego-G
approved these changes
Oct 24, 2019
shuse2
approved these changes
Oct 25, 2019
MaciejBaj
approved these changes
Oct 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Peers can send unnecessary or internal messages that are not part of the protocol.
How did I solve it?
Rejecting the message and banning the peer.
How to manually test it?
Send messages like
INVALIDor something and see if the receiving node rejects the connectionReview checklist