This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Improve logging when a transaction fails due to verifyPartnerChainOutboxRoot #9111
Assignees
Labels
Milestone
Comments
ishantiw
added
type: bug
framework/module/interoperability
ishantiw
added a commit
that referenced
this issue
Oct 20, 2023
- Create Panic function to exit application on unexpected error while CCU execution - Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111 - Rename executeCommon->beforeCrossChainMessagesExecution - Add verifyRoutingRules similar to LIP0053 - Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112 - Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
ishantiw
added a commit
that referenced
this issue
Oct 21, 2023
- Create Panic function to exit application on unexpected error while CCU execution - Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111 - Rename executeCommon->beforeCrossChainMessagesExecution - Add verifyRoutingRules similar to LIP0053 - Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112 - Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
ishantiw
added a commit
that referenced
this issue
Oct 22, 2023
* ♻️ Update getChildQueue to replace default topic - getChildQueue is updated to replace default topic - Transaction execution to have a transactionID with prefix as default topic - CCM execution to have a ccmID with prefix as default topic * ♻️ Add prefix to txID when call unsafeAdd * ♻️ Handle ccm processing error #9100 - Create Panic function to exit application on unexpected error while CCU execution - Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111 - Rename executeCommon->beforeCrossChainMessagesExecution - Add verifyRoutingRules similar to LIP0053 - Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112 - Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module * ✅ Add and update tests for CCU execute and verifyPartnerChainOutboxRoot * 💅🏻 Fix lint error * 💅🏻 Apply feedback comments
34 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
When a transaction execution fails in
verifyPartnerChainOutboxRootduring CCU execution, it should log a proper message and log an eventActual behavior
Currently when the command fails on
verifyPartnerChainOutboxRootthere is no error message or event related to it.Related LIP PR to fix it by,
EVENT_NAME_INVALID_OUTBOX_ROOT_VERIFICATIONevent onverifyPartnerChainOutboxRootfailure as well as on SMT failure.verifyPartnerChainOutboxRootandverifyCertificateSignatureare taken out frombeforeCrossChainMessagesExecutionso now transaction will fail if any of these 2 functions will fail.Steps to reproduce
Submit a CCU with invalid
PartnerChainOutboxRootWhich version(s) does this affect? (Environment, OS, etc...)
6.0.0-rc.3The text was updated successfully, but these errors were encountered: