Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

commandExecutionResult event should be logged after afterCommandExecute hook #7944

Closed
Tracked by #7210
shuse2 opened this issue Jan 4, 2023 · 0 comments · Fixed by #7991
Closed
Tracked by #7210

commandExecutionResult event should be logged after afterCommandExecute hook #7944

shuse2 opened this issue Jan 4, 2023 · 0 comments · Fixed by #7991

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Jan 4, 2023

Expected behavior

  • commandExecutionResult event should be the last event for transaction execution

Actual behavior

Dry run shows

{
      "result":0,
      "events":[
         {
            "data":"0a14cdac35270a8bcb46552caffcbfa7dbcc1c87fcca12036665651a08040000000000000020f0900a2800",
            "index":0,
            "module":"token",
            "name":"lock",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683",
               "cdac35270a8bcb46552caffcbfa7dbcc1c87fcca"
            ],
            "height":379
         },
         {
            "data":"",
            "index":1,
            "module":"fee",
            "name":"insufficientFee",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683"
            ],
            "height":379
         },
         {
            "data":"0800",
            "index":2,
            "module":"token",
            "name":"commandExecutionResult",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683"
            ],
            "height":379
         },
         {
            "data":"0a14cdac35270a8bcb46552caffcbfa7dbcc1c87fcca12036665651a08040000000000000020f0900a2800",
            "index":3,
            "module":"token",
            "name":"unlock",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683",
               "cdac35270a8bcb46552caffcbfa7dbcc1c87fcca"
            ],
            "height":379
         },
         {
            "data":"0a14cdac35270a8bcb46552caffcbfa7dbcc1c87fcca1208040000000000000018f0900a2000",
            "index":4,
            "module":"token",
            "name":"burn",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683",
               "cdac35270a8bcb46552caffcbfa7dbcc1c87fcca"
            ],
            "height":379
         },
         {
            "data":"0a14cdac35270a8bcb46552caffcbfa7dbcc1c87fcca121483eb47425f89f534184b4e40663d72843f5da1d91a08040000000000000020002800",
            "index":5,
            "module":"token",
            "name":"transfer",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683",
               "cdac35270a8bcb46552caffcbfa7dbcc1c87fcca",
               "83eb47425f89f534184b4e40663d72843f5da1d9"
            ],
            "height":379
         },
         {
            "data":"0a14cdac35270a8bcb46552caffcbfa7dbcc1c87fcca121483eb47425f89f534184b4e40663d72843f5da1d918f0900a2000",
            "index":6,
            "module":"fee",
            "name":"generatorFeeProcessed",
            "topics":[
               "00f53939f904231e7875361f095c57263ddaa78de6d8e367817b916edc954683",
               "cdac35270a8bcb46552caffcbfa7dbcc1c87fcca",
               "83eb47425f89f534184b4e40663d72843f5da1d9"
            ],
            "height":379
         }
      ]

Steps to reproduce

Call dry run on transaction

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-alpha.9

shuse2 pushed a commit that referenced this issue Jan 13, 2023
…te hook (#7991)

### What was the problem?

This PR resolves #7944 

### How was it solved?

Change order of events

### How was it tested?

Update unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant