Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Math library fails to create Q from empty buffer #7788

Closed
Incede opened this issue Nov 16, 2022 · 0 comments
Closed

Math library fails to create Q from empty buffer #7788

Incede opened this issue Nov 16, 2022 · 0 comments
Assignees
@Incede
Labels
elements/utils type: bug
Milestone
Sprint 82

Comments

@Incede
Copy link
Contributor

Incede commented Nov 16, 2022

Expected behavior

Empty buffer as input should be initialized as a Q with value 0

Actual behavior

Fails with error SyntaxError: Cannot convert 0x to a BigInt

Steps to reproduce

q96(Buffer.alloc(0))

Which version(s) does this affect? (Environment, OS, etc...)

feature/7622-update-dpos-module
@Incede Incede mentioned this issue Nov 17, 2022
Merged
shuse2 added a commit that referenced this issue Nov 18, 2022
@Incede @shuse2
Add method updateSharedRewards for DPoS module (#7793)
2e9a4c0 
### What was the problem?

This PR resolves #7715 #7788

### How was it solved?

* Fix bug in Q library
* Add method as specified

### How was it tested?

Added unit tests

Co-authored-by: shuse2 <[email protected]>
@shuse2 shuse2 added this to the Sprint 82 milestone Nov 18, 2022
@shuse2 shuse2 closed this as completed Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
elements/utils type: bug
Projects
None yet
Milestone
Sprint 82
Development

No branches or pull requests
2 participants
@shuse2 @Incede