Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update cross chain commands #7575

Closed
Tracked by #7211
shuse2 opened this issue Sep 23, 2022 · 2 comments
Closed
Tracked by #7211

Update cross chain commands #7575

shuse2 opened this issue Sep 23, 2022 · 2 comments
Assignees
@mosmartin
Labels
framework
Milestone
Sprint 81

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Sep 23, 2022 •
edited
Loading

Description

  • Remove CCForwardCommand
  • Update CrossChainTransferCommand as specified in the PR

Acceptance Criteria

  • CCForwardCommand src and tests are removed
  • Updated CrossChainTransferCommand is unit tested

Additional Information
@shuse2 shuse2 added this to the Sprint 79 milestone Sep 26, 2022
@shuse2 shuse2 mentioned this issue Sep 26, 2022
Closed
71 tasks
@mosmartin mosmartin self-assigned this Sep 28, 2022
@mosmartin
Copy link
Contributor

@shuse2 CCForwardCommand is a class right? (framework/src/modules/token/cc_commands/cc_forward.ts)

@shuse2
Copy link
Collaborator Author

shuse2 commented Sep 28, 2022

yes that is a class

@mosmartin mosmartin mentioned this issue Oct 7, 2022
Closed
@shuse2 shuse2 modified the milestones: Sprint 79, Sprint 80 Oct 10, 2022
@mosmartin mosmartin mentioned this issue Oct 14, 2022
Merged
shuse2 added a commit that referenced this issue Oct 24, 2022
@shuse2
Update cross chain command - Closes #7575 (#7641)
5bb1ccc 
### What was the problem?

This PR resolves #7575

### How was it solved?

- Remove CCForwardCommand from src and unit tests
- Rename CCTransferCommand to CrossChainTransferCommand
- Add verify() method
- Refactor the execute method
- Update constants
- Update the module init() method

### How was it tested?

- Added unit tests
@shuse2 shuse2 closed this as completed Oct 24, 2022
@shuse2 shuse2 modified the milestones: Sprint 80, Sprint 81 Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mosmartin mosmartin

Labels
framework
Projects
None yet
Milestone
Sprint 81
Development

No branches or pull requests
2 participants
@shuse2 @mosmartin