Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update error method of interoperability module #7564

Closed
Tracked by #7211
ishantiw opened this issue Sep 23, 2022 · 0 comments
Closed
Tracked by #7211

Update error method of interoperability module #7564

ishantiw opened this issue Sep 23, 2022 · 0 comments
Labels
framework/module/interoperability Interoperability module
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Sep 23, 2022

Description

Update error method of BaseInteroperabilityMethod (mainchain/sidechain) module

def error(ccm: CCM, errorStatus: uint32) -> None:
    # Error codes from 0 to MAX_RESERVED_ERROR_STATUS (included) are reserved to the Interoperability module
    if 0 <= errorStatus <= MAX_RESERVED_ERROR_STATUS:
        raise Exception('Invalid error status.')

    return send(
        EMPTY_FEE_ADDRESS,
        ccm.module,
        ccm.crossChainCommand,
        ccm.sendingChainID,
        0,
        errorStatus,
        ccm.params
    )

Acceptance Criteria

  • Should have corresponding unit tests

Additional Information

@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Sep 23, 2022
@shuse2 shuse2 added this to the Sprint 79 milestone Sep 26, 2022
@shuse2 shuse2 modified the milestones: Sprint 79, Sprint 80 Oct 10, 2022
@shuse2 shuse2 modified the milestones: Sprint 80, Sprint 81 Oct 24, 2022
@shuse2 shuse2 assigned shuse2 and unassigned shuse2 Nov 7, 2022
@shuse2 shuse2 modified the milestones: Sprint 81, Sprint 82 Nov 7, 2022
ishantiw added a commit that referenced this issue Nov 17, 2022
### What was the problem?

This PR resolves #7564 #7702 

### How was it solved?

♻️ Improve contexts for interoperability methods

🌱 Implement error method

### How was it tested?

- Build should pass
- `npm t`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework/module/interoperability Interoperability module
Projects
None yet
Development

No branches or pull requests

2 participants