Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update auth module block processing hooks #7346

Closed
Tracked by #7211
ishantiw opened this issue Jul 26, 2022 · 0 comments · Fixed by #7395
Closed
Tracked by #7211

Update auth module block processing hooks #7346

ishantiw opened this issue Jul 26, 2022 · 0 comments · Fixed by #7395
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jul 26, 2022

Description

  • Update transaction verification part according to LIP0041:Block Processing:Transaction Verification which is basically implemented using below functions as described in the LIP

    • verifyTransaction
    • verifyNonce
    • verifySignatures
  • Update beforeCommandExecution

  • Implement/update endpoints described in the LIP0041

  • Use verifyNonceStrict for the endpoint which follows the same implementation described in this LIP0041 section.

  • For verifyNonce implementation, we want future transactions to be accepted in the TxPool so we update the condition to reject transaction for trs.nonce < account.nonce and we call this function in verifyTransaction

  • Remove afterCommandExecute hook from auth module

Acceptance Criteria

  • Update/Add unit tests covering all the conditions for each function separately and the Verify function itself
  • Update unit tests for beforeCommandExecution

Additional Information

@ishantiw ishantiw changed the title Update auth module transaction verification Update auth module block processing hooks Jul 26, 2022
@milenagojkovic milenagojkovic added this to the Sprint 75 milestone Aug 1, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 75, Sprint 76 Aug 14, 2022
ishantiw added a commit that referenced this issue Aug 22, 2022
…ocessing-hooks

Update auth module block processing hooks - Closes #7346
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants