Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update tests for new encryption and decryption #7235

Closed
Tracked by #7210
mitsuaki-u opened this issue Jun 21, 2022 · 0 comments · Fixed by #7270
Closed
Tracked by #7210

Update tests for new encryption and decryption #7235

mitsuaki-u opened this issue Jun 21, 2022 · 0 comments · Fixed by #7270
Assignees
@mitsuaki-u
Labels
commander elements/client elements/cryptography
Milestone
Sprint 73

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Jun 21, 2022 •
edited by ishantiw
Loading

Description

After PR #7216,

  • Bring back Lisk Client tests and fix them 1fba51f
  • Use different iterations values for encrypt unit tests

Resolve below points:

Remove comment: https://github.com/LiskHQ/lisk-sdk/pull/7216/files#diff-94c94ac3f34df4ab8e696abaee8a0b027ae7048235ec1d85874af0ae33c6feccR50

Remove comment: https://github.com/LiskHQ/lisk-sdk/pull/7216/files#diff-83a5e47649899cfcd950311c52a0a8b34d4c478c1c686bd1018c4414c2b74a63R62

Remove comment: https://github.com/LiskHQ/lisk-sdk/pull/7216/files#diff-c6b4198921fe380206a356f4e5485ced590663f893499e7a5e36434a13a685d5R104

Enable test and fix it: https://github.com/LiskHQ/lisk-sdk/pull/7216/files#diff-c6b4198921fe380206a356f4e5485ced590663f893499e7a5e36434a13a685d5R93

Acceptance Criteria

  • Lisk client cryptography/encrypt.spec tests should be present and all should pass
  • Resolve all the open points listed in the issue
  • Test the PR branch with Lisk core and report any issues found to be fixed in order to make Lisk core working with the development
@mitsuaki-u mitsuaki-u self-assigned this Jun 21, 2022
@milenagojkovic milenagojkovic added this to the Sprint 72 milestone Jun 22, 2022
@mitsuaki-u mitsuaki-u changed the title Update commander tests for new encryption and decryption Update tests for new encryption and decryption Jun 28, 2022
@milenagojkovic milenagojkovic mentioned this issue Jun 29, 2022
Closed
@mitsuaki-u mitsuaki-u mentioned this issue Jun 30, 2022
Merged
@milenagojkovic milenagojkovic modified the milestones: Sprint 72, Sprint 73 Jul 3, 2022
ishantiw added a commit that referenced this issue Jul 7, 2022
@ishantiw
Merge pull request #7270 from LiskHQ/7235_encrypt_test
6e5ebe3 
Update tests for new encryption and decryption - Closes #7235
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitsuaki-u mitsuaki-u

Labels
commander elements/client elements/cryptography
Projects
None yet
Milestone
Sprint 73
Development

Successfully merging a pull request may close this issue.

Update tests for new encryption and decryption - Closes #7235 LiskArchive/lisk-sdk
3 participants
@milenagojkovic @ishantiw @mitsuaki-u