Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Search for common block should look until finalized height #6990

Closed
Tracked by #7210
shuse2 opened this issue Jan 19, 2022 · 0 comments · Fixed by #7639
Closed
Tracked by #7210

Search for common block should look until finalized height #6990

shuse2 opened this issue Jan 19, 2022 · 0 comments · Fixed by #7639
Assignees
@Incede
Labels
framework type: bug
Milestone
Sprint 80

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Jan 19, 2022 •
edited
Loading

Description

While searching for the common block while block synchronization, it look 10 rounds for 3 times, but it should look until finalized height.

Motivation

While synchronization, we look into 10 rounds of blocks for 3 times but it should be capped at the finalized height.

Additional Information
@milenagojkovic milenagojkovic mentioned this issue Aug 2, 2022
Closed
@milenagojkovic milenagojkovic added this to the Sprint 76 milestone Aug 15, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 76, Sprint 77 Aug 28, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 77, Sprint 78 Sep 11, 2022
@shuse2 shuse2 added this to the Sprint 80 milestone Oct 10, 2022
@Incede Incede self-assigned this Oct 12, 2022
@Incede Incede mentioned this issue Oct 14, 2022
Merged
shuse2 added a commit that referenced this issue Oct 17, 2022
@shuse2
Merge pull request #7639 from LiskHQ/6990-common-block
90872d3 
Search for common block should look until finalized height - Closes #6990
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
framework type: bug
Projects
None yet
Milestone
Sprint 80
Development

Successfully merging a pull request may close this issue.

Search for common block should look until finalized height - Closes #6990 LiskArchive/lisk-sdk
3 participants
@shuse2 @milenagojkovic @Incede