Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove channel input from load function of base plugin #6902

Closed
shuse2 opened this issue Nov 12, 2021 · 0 comments · Fixed by #7007
Closed

Remove channel input from load function of base plugin #6902

shuse2 opened this issue Nov 12, 2021 · 0 comments · Fixed by #7007
Assignees
@Incede
Labels
framework framework-plugins/dashboard framework-plugins/faucet framework-plugins/forging framework-plugins/monitor framework-plugins/report_misbehavior type: refactoring
Milestone
Sprint 63

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 12, 2021

Description

  • Update base plugin definition of load function to below because channel is passed in init function already
public abstract load(): Promise<void>;

Acceptance Criteria

  • All existing plugins interface are updated
  • All build and tests are passing
@shuse2 shuse2 added this to the Sprint 59 milestone Dec 6, 2021
@milenagojkovic milenagojkovic removed this from the Sprint 59 milestone Dec 20, 2021
@shuse2 shuse2 self-assigned this Jan 15, 2022
@shuse2 shuse2 added this to the Sprint 61 milestone Jan 15, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 61, Sprint 62 Jan 29, 2022
@shuse2 shuse2 removed their assignment Jan 31, 2022
@Incede Incede self-assigned this Feb 8, 2022
@Incede Incede mentioned this issue Feb 8, 2022
Merged
@shuse2 shuse2 linked a pull request Feb 8, 2022 that will close this issue
Remove channel input from load function of base plugin - Closes #6902 #7007
Merged
@milenagojkovic milenagojkovic modified the milestones: Sprint 62, Sprint 63 Feb 14, 2022
shuse2 added a commit that referenced this issue Feb 18, 2022
@shuse2
Merge pull request #7007 from LiskHQ/6902-remove-input
3b5c750 
 Remove channel input from load function of base plugin - Closes #6902
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
framework framework-plugins/dashboard framework-plugins/faucet framework-plugins/forging framework-plugins/monitor framework-plugins/report_misbehavior type: refactoring
Projects
None yet
Milestone
Sprint 63
Development

Successfully merging a pull request may close this issue.

Remove channel input from load function of base plugin - Closes #6902 LiskArchive/lisk-sdk
3 participants
@shuse2 @milenagojkovic @Incede