Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add aggregateCommit when a block reaches certificateThreshold in generator #6852

Closed
Tracked by #6837
ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6975
Closed
Tracked by #6837

Add aggregateCommit when a block reaches certificateThreshold in generator #6852

ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6975
Assignees
@Incede
Labels
framework
Milestone
Sprint 60

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Oct 18, 2021 •
edited
Loading

Description

Generator calls consensus.getAggregateCommit() in block creation (_generateBlock()) after the block execute step.

  1. create a function in consensus as getAggregateCommit(apiContext) that calls commitPool.getAggregateCommit()
  2. In generator, call this._consensus.getAggregateCommit(apiContext)
  3. Assign result from above to blockheader.aggregateCommit = await this._consensus.getAggregateCommit(apiContext)

Acceptance Criteria

  • Add unit tests for a non-default aggregateCommit and default aggregateCommit scenarios
@ishantiw ishantiw mentioned this issue Oct 18, 2021
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 58 milestone Nov 19, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 58 milestone Nov 22, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 59 milestone Dec 6, 2021
@milenagojkovic milenagojkovic removed this from the Sprint 59 milestone Dec 20, 2021
@Incede Incede self-assigned this Jan 3, 2022
@milenagojkovic milenagojkovic added this to the Sprint 60 milestone Jan 3, 2022
@Incede Incede mentioned this issue Jan 11, 2022
Merged
@shuse2 shuse2 linked a pull request Jan 12, 2022 that will close this issue
Add aggregateCommit when a block reaches certificateThreshold in generator - Closes #6852 #6975
Merged
shuse2 added a commit that referenced this issue Jan 13, 2022
@shuse2
Merge pull request #6975 from LiskHQ/6852-add-commit-generator
549523c 
 Add aggregateCommit when a block reaches certificateThreshold in generator - Closes #6852
@shuse2 shuse2 closed this as completed Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
framework
Projects
None yet
Milestone
Sprint 60
5 participants
@shuse2 @milenagojkovic @ishantiw @Incede @sridharmeganathan