Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement selectAggregateCommit of CommitPool #6846

Closed
Tracked by #6837
ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6958
Closed
Tracked by #6837

Implement selectAggregateCommit of CommitPool #6846

ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6958
Assignees
@mitsuaki-u
Labels
framework
Milestone
Sprint 59

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Oct 18, 2021 •
edited
Loading

Description

public getAggregageCommit() {
  return  this._aggregateSingleCommits(this._selectAggregateCommit());
};

Acceptance Criteria

  • Add unit test for selectAggregateCommit
@ishantiw ishantiw mentioned this issue Oct 18, 2021
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 58 milestone Nov 19, 2021
@mitsuaki-u mitsuaki-u self-assigned this Nov 30, 2021
@mitsuaki-u mitsuaki-u mentioned this issue Dec 2, 2021
Merged
@milenagojkovic milenagojkovic modified the milestones: Sprint 58, Sprint 59 Dec 6, 2021
mitsuaki-u added a commit that referenced this issue Dec 8, 2021
@mitsuaki-u
Merge pull request #6958 from LiskHQ/6846_select_aggregate
2b91c4f 
Implement select aggregate commit in commit pool - Closes #6846
@shuse2 shuse2 linked a pull request Mar 28, 2022 that will close this issue
Implement select aggregate commit in commit pool - Closes #6846 #6958
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitsuaki-u mitsuaki-u

Labels
framework
Projects
None yet
Milestone
Sprint 59
Development

Successfully merging a pull request may close this issue.

Implement select aggregate commit in commit pool - Closes #6846 LiskArchive/lisk-sdk
6 participants
@shuse2 @milenagojkovic @ishantiw @mehmetegemen @mitsuaki-u @sridharmeganathan