This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Remove asset field from base transaction - Closes #989 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the title
mitsuaki-u
approved these changes
Jan 10, 2019
shuse2
force-pushed
the
989-remove_asset_from_base
branch
from
9a493de to
1b400b1
Compare
SargeKhan
reviewed
Jan 10, 2019
| @@ -101,7 +98,7 @@ export abstract class BaseTransaction { | |||
| this.receivedAt = rawTransaction.receivedAt; | |||
| } | |||
|
|
|||
| public abstract assetToJSON(): TransactionAsset; | |||
| public abstract assetToJSON(): object; | |||
There was a problem hiding this comment.
Why is it no longer of type TransactionAsset?
There was a problem hiding this comment.
Since asset type is defined in each child transaction, we can't expect it to be specific type.
Maybe we can use generics here, but it's only used in this class, so it wont make much sense?
shuse2
force-pushed
the
989-remove_asset_from_base
branch
from
1b400b1 to
da34780
Compare
SargeKhan
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
In order to make the base transaction more flexible yet type safe, asset should not be defined in the base transaction.
How did I fix it?
Remove the asset field from the base transaction
Review checklist