This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Multisignature registration sets to pending when signatures missing - Closes #1106 #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
changed the title
shuse2
previously approved these changes
Feb 16, 2019
mitsuaki-u
force-pushed
the
1106_multisig_registration_pending
branch
from
936d9d1 to
d014071
Compare
shuse2
approved these changes
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Type 4 multisig registration transactions were not checking transaction signatures and properly setting to pending if missing.
How did I fix it?
Added check and verification of transaction signatures in
applystage for multisig transactions.How to test it?
npm test
Review checklist