Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Add get or default to explicitly get the default account #1093

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Add get or default to explicitly get the default account #1093

merged 2 commits into from
Feb 12, 2019

Conversation

shuse2
Copy link
Contributor

@shuse2 shuse2 commented Feb 11, 2019

What was the problem?

It was ambiguous when account get initialized by default value.

How did I fix it?

Add getOrDefault function from store

How to test it?

npm t

Review checklist

@shuse2 shuse2 self-assigned this Feb 11, 2019
@shuse2 shuse2 requested a review from SargeKhan February 11, 2019 17:24
@shuse2 shuse2 requested a review from mitsuaki-u February 11, 2019 17:24
mitsuaki-u
mitsuaki-u approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be named getOrCreate?

@shuse2
Copy link
Contributor Author

shuse2 commented Feb 12, 2019

@mitsujutsu I think user cannot create, so default in this case would be better

@shuse2 shuse2 merged commit e35b979 into development Feb 12, 2019
@shuse2 shuse2 deleted the 1091-add_get_or_default branch February 12, 2019 10:47
@shuse2 shuse2 mentioned this pull request Feb 13, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

@SargeKhan SargeKhan SargeKhan approved these changes

Assignees

@shuse2 shuse2

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuse2 @SargeKhan @mitsuaki-u