Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Disable tslint config #826

Closed
shuse2 opened this issue Oct 19, 2018 · 0 comments
Closed

Disable tslint config #826

shuse2 opened this issue Oct 19, 2018 · 0 comments
Assignees
@shuse2
Labels
*easy 🏠 chore lisk-elements

Comments

@shuse2
Copy link
Contributor

shuse2 commented Oct 19, 2018 •
edited
Loading

Description

  • object-literal-sort-keys: false
    Often in our system, object keys has meaning in order other than alphabetical.
    For example, transaction.asset should be the last elements.

  • strict-type-predicates: false
    Although we are converting to typescript, we have a lot of code to check the types of the variable.
    Checking the types is safer and better than trusting the developer 100%

  • file-name-casing: false
    File name casting does not support snake_case
@shuse2 shuse2 self-assigned this Oct 19, 2018
@shuse2 shuse2 changed the title Disable tslint config for strict-type-predicates and object-literal-sort-keys Disable tslint config Oct 19, 2018
@shuse2 shuse2 mentioned this issue Oct 19, 2018
Merged
shuse2 added a commit that referenced this issue Oct 23, 2018
@shuse2
Merge pull request #827 from LiskHQ/826-disable_lint_configs
bf52f49 
Disable Filename, object odering, and type predicates - Closes #826
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
*easy 🏠 chore lisk-elements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuse2