Merge pull request #738 from LiskHQ/710-buffer-reverse

Use React Native/Android-compatible buffer reverse function - Closes #710
LiskArchive · Jul 23, 2018 · 4ba6e63 · 4ba6e63
2 parents f0fe09a + 13a092d
commit 4ba6e63
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -67,6 +67,7 @@
     "babel-runtime": "=6.26.0",
     "bip39": "=2.4.0",
     "browserify-bignum": "=1.3.0-2",
+    "buffer-reverse": "=1.0.1",
     "ed2curve": "=0.2.1",
     "tweetnacl": "=1.0.0",
     "varuint-bitcoin": "=1.1.0"

diff --git a/src/cryptography/convert.js b/src/cryptography/convert.js
@@ -14,6 +14,7 @@
  */
 import querystring from 'querystring';
 import bignum from 'browserify-bignum';
+import reverseBuffer from 'buffer-reverse';
 import ed2curve from 'ed2curve';
 import hash from './hash';
 
@@ -41,9 +42,7 @@ export const hexToBuffer = hex => {
 };
 
 export const getFirstEightBytesReversed = publicKeyBytes =>
-	Buffer.from(publicKeyBytes)
-		.slice(0, 8)
-		.reverse();
+	reverseBuffer(Buffer.from(publicKeyBytes).slice(0, 8));
 
 export const toAddress = buffer => {
 	if (