Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix closing DB which leaves the database locked #79

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

hrmhatef
Copy link
Contributor

@hrmhatef hrmhatef commented Dec 6, 2022

What was the problem?

This PR resolves #78

How was it solved?

  • Refactor the DB to stores an option of DB and change it to None in close function.

How was it tested?

  • Add a new unit test to check the new implementation.
  • All tests passed.

@hrmhatef hrmhatef self-assigned this Dec 6, 2022
@hrmhatef hrmhatef force-pushed the 78_closing_db_with_release_lock branch from 99e4f80 to 99361bc Compare December 6, 2022 11:48
@hrmhatef hrmhatef force-pushed the 78_closing_db_with_release_lock branch from 99361bc to bdde4df Compare December 6, 2022 11:53
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Commit SHA:dcc7d5eacd955a2f28068618f39ae62c4e57949e

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 78_closing_db_with_release_lock 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 84.91 (1.64) 67.17 (1.53) 93 (2.1) 84.81 (1.65)
🟢 database.js 80.16 (3.31) 61.22 (2.04) 86.15 (4.62) 80.16 (3.31)
🟢 state_db.js 89.14 (0.77) 70.31 (1.56) 98.33 (0) 89.14 (0.77)

@shuse2 shuse2 merged commit 63b19d8 into main Dec 6, 2022
@shuse2 shuse2 deleted the 78_closing_db_with_release_lock branch December 6, 2022 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing DB leaves the database locked
3 participants