This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Update delegate commands to typescript - Closes #657 #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
656-update_config_cmd_ts
branch
from
52096a5 to
2607f13
Compare
shuse2
force-pushed
the
657-update_delegate_cmd_ts
branch
from
3544352 to
9795fa7
Compare
shuse2
force-pushed
the
657-update_delegate_cmd_ts
branch
from
9795fa7 to
859cf5e
Compare
shuse2
changed the base branch from
656-update_config_cmd_ts
to
649-convert_to_typescript
ishantiw
reviewed
Dec 12, 2018
src/commands/delegate/votes.ts
Outdated
| @@ -42,7 +49,7 @@ const processFlagInputs = (limitStr, offsetStr, sortStr) => { | |||
| ) { | |||
| throw new Error('Offset must be an integer and greater than or equal to 0'); | |||
| } | |||
| if (!VOTES_SORT_FIELDS.includes(sort)) { | |||
| if (sort !== undefined && !VOTES_SORT_FIELDS.includes(sort)) { | |||
There was a problem hiding this comment.
Maybe use falsy to check if undefined !sort
ishantiw
reviewed
Dec 12, 2018
ishantiw
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update delegate commands to typescript
Review checklist