This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add show account - Closes #540 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
previously requested changes
Jun 11, 2018
src/commands/show_account.js
Outdated
| import commonOptions from '../utils/options'; | ||
| import cryptography from '../utils/cryptography'; | ||
|
|
||
| const description = `Shows an account information with the given passphrase. |
There was a problem hiding this comment.
Shows account information for a given passphrase
src/commands/show_account.js
Outdated
|
|
||
| const description = `Shows an account information with the given passphrase. | ||
|
|
||
| Examples: show account |
src/commands/show_account.js
Outdated
| `; | ||
|
|
||
| const processInput = ({ passphrase }) => | ||
| cryptography.liskCrypto.getAddressAndPublicKeyFromPassphrase(passphrase); |
There was a problem hiding this comment.
Do we also want to provide the private key? We do when creating an account.
test/specs/commands/show_account.js
Outdated
| given.aPassphrase, | ||
| () => { | ||
| Given( | ||
| 'an object with the public key "314852d7afb0d4c283692fef8a2cb40e30c7a5df2ed79994178c10ac168d6d977ef45cd525e95b7a86244bbd4eb4550914ad06301013958f4dd64d32ef7bc588" and the address "2167422481642255385L" derived from the passphrase', |
There was a problem hiding this comment.
Did you consider reusing the given step which defines a passphrase and these additional items together?
test/specs/commands/show_account.js
Outdated
| when.theActionIsCalledWithTheOptions, | ||
| () => { | ||
| Then( | ||
| 'it should resolve to an object with the public key and the address', |
There was a problem hiding this comment.
How did the action know about the passphrase in this scenario?
test/specs/commands/show_account.js
Outdated
| given.anEmptyOptionsObject, | ||
| () => { | ||
| When( | ||
| 'the action is called with the options', |
There was a problem hiding this comment.
What's the point of this branch?
test/specs/commands/show_account.js
Outdated
| given.anObjectWithThePublicKeyAndTheAddressDerivedFromThePassphrase, | ||
| () => { | ||
| Given( | ||
| 'an empty options object', |
There was a problem hiding this comment.
What about with the passphrase passed as an option?
test/steps/crypto/1_given.js
Outdated
| @@ -216,3 +216,18 @@ export function anEncryptedMessageWithANonce() { | |||
|
|
|||
| this.test.ctx.cipherAndNonce = cipherAndNonce; | |||
| } | |||
|
|
|||
| export function anObjectWithThePublicKeyAndTheAddressDerivedFromThePassphrase() { | |||
There was a problem hiding this comment.
This step doesn't define an object at all.
shuse2
force-pushed
the
540-add_show_account
branch
from
2d8bebb to
6701798
Compare
shuse2
force-pushed
the
540-add_show_account
branch
from
6701798 to
8045294
Compare
willclarktech
previously requested changes
Jun 13, 2018
src/commands/show_account.js
Outdated
|
|
||
| const description = `Shows account information for a given passphrase. | ||
|
|
||
| Example: show account |
There was a problem hiding this comment.
Should be tab-indented.
| given.aVorpalInstanceWithAUIAndAnActiveCommandThatCanPrompt, | ||
| () => { | ||
| Given('an action "show account"', given.anAction, () => { | ||
| Given( |
There was a problem hiding this comment.
This step is now redundant.
test/specs/commands/show_account.js
Outdated
| () => { | ||
| Then( | ||
| 'it should resolve to an object with the public key, the private key and the address', | ||
| then.itShouldResolveToAnObjectWithThePublicKeyThePrivateKeyAndTheAddress, |
There was a problem hiding this comment.
Prefer a consistent ordering reflecting the derivation direction: in general passphrase -> privateKey -> publicKey -> address.
test/specs/commands/show_account.js
Outdated
| () => { | ||
| Given( | ||
| 'an options object with passphrase set to "passphraseSource"', | ||
| given.anOptionsObjectWithPassphraseSetTo, |
There was a problem hiding this comment.
Can the passphrase be retrieved? What if it can? What if it can't?
willclarktech
suggested changes
Jun 13, 2018
test/specs/commands/show_account.js
Outdated
| then.itShouldGetTheInputsFromSourcesUsingThePassphraseSourceWithARepeatingPrompt, | ||
| ); | ||
| Then( | ||
| 'it should resolve to an object withthe private key, the public key and the address', |
test/specs/commands/show_account.js
Outdated
| then.itShouldGetTheInputsFromSourcesUsingThePassphraseSourceWithARepeatingPrompt, | ||
| ); | ||
| Then( | ||
| 'it should resolve to an object withthe private key, the public key and the address', |
shuse2
force-pushed
the
540-add_show_account
branch
from
2711d07 to
201d7fb
Compare
willclarktech
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
show accountcommandReview checklist