Add support for retrieving module ids from device #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scottmckenzie. Thanks for the PR. Everything looks fine. I will just test it out on my plugs and if everything checks out we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by PR#20 I found that the module ids can be retrieved from the device by calling GetModuleProfile. This means they don't have to be hard-coded.
The SOAPAction method was originally written to return a text value from the SOAP response. I have modified this to return the raw SOAP response. I have then added two new methods:
Default module ids are configured in init before reading the actual values from the device. I have test this on two AU devices one with v1.13 A1 firmware and one with 1.23 A2 firmware.
I don't have any B series firmware devices to test against. As long as the module subtypes (on lines 225 & 227) match it should work. This needs to be tested though.