ELIF typo #3285
Open
ELIF typo #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to exclude all the ...rc.py files from your commit. |
|
@c-morley will probably have something to say about this. |
|
Wouldn't it be better to commit the sources and use make + Qt resource compiler to create the compiled resource .py files? |
|
Why do you think the if should be elif? I don't think it should. I don't know what all the '_rc' code is about, but it shouldn't be included. Please let us know what problem you are trying to fix. |
|
I compared it against the same Def from the other handler files.
Jan 15, 2025 7:42:23 AM c-morley ***@***.***>:
…
Why do you think the if should be elif? I don't think it should.
I don't know what all the '_rc' code is about, but it shouldn't be included.
Please let us know what problem you are trying to fix.
—
Reply to this email directly, view it on GitHub[#3285 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABFIKPICZIZ6T6AMKYBFY332KZQT5AVCNFSM6AAAAABVF4MJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJSHA4TAOJZHA].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/ABFIKPNL4IGPEIIRVS4K7WD2KZQT5A5CNFSM6AAAAABVF4MJ2SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2RRQHM.gif]
|
|
What problem are you trying to fix ? |
|
I guess it might be the question why is it different from this, there are other examples: |
|
There was no “problem” other than consistency across “like” files and class definitions.
I’ve added “*_rc.py” to my ignore file.
If you are not comfortable with the change I can either pull it back or you may cancel/delete it.
Andy
From: c-morley ***@***.***>
Sent: Wednesday, January 15, 2025 7:42 AM
To: LinuxCNC/linuxcnc ***@***.***>
Cc: Andy (gardenweazel) Lewis ***@***.***>; Author ***@***.***>
Subject: Re: [LinuxCNC/linuxcnc] ELIF typo (PR #3285)
Why do you think the if should be elif? I don't think it should.
I don't know what all the '_rc' code is about, but it shouldn't be included.
Please let us know what problem you are trying to fix.
—
Reply to this email directly, view it on GitHub <#3285 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFIKPICZIZ6T6AMKYBFY332KZQT5AVCNFSM6AAAAABVF4MJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJSHA4TAOJZHA> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ABFIKPNL4IGPEIIRVS4K7WD2KZQT5A5CNFSM6AAAAABVF4MJ2SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2RRQHM.gif> Message ID: ***@***.*** ***@***.***> >
|
|
The resource files were committed inadvertently.
*_rc.py has been added to my ignore file.
From: BsAtHome ***@***.***>
Sent: Wednesday, January 15, 2025 7:33 AM
To: LinuxCNC/linuxcnc ***@***.***>
Cc: Andy (gardenweazel) Lewis ***@***.***>; Author ***@***.***>
Subject: Re: [LinuxCNC/linuxcnc] ELIF typo (PR #3285)
Wouldn't it be better to commit the sources and use make + Qt resource compiler to create the compiled resource .py files?
Embedding compiled resources like this is IMO bad coding style and each change generates huge opaque diffs.
—
Reply to this email directly, view it on GitHub <#3285 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFIKPIGAGOO75BXDPMVHJD2KZPPJAVCNFSM6AAAAABVF4MJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJSHA3DQMZSGI> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ABFIKPMHKBQSG6OL6P72KVT2KZPPJA5CNFSM6AAAAABVF4MJ2SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2RQD6E.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Ok ill look into the other screen code to check the logic. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed line 676 from IF to ELIF