pull the latest version of mono instead of pinning to an old version #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
suggested changes
Mar 31, 2020
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM mono:3.12.1 as builder | |||
| FROM mono as builder | |||
| ARG CHOCOVERSION=stable | |||
|
|
|||
| RUN echo "deb http://archive.debian.org/debian/ wheezy main contrib non-free" >/etc/apt/sources.list | |||
There was a problem hiding this comment.
I don't think this line should be here; Current version of mono is based on Debian 9 stretch.
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM mono:3.12.1 as builder | |||
| FROM mono as builder | |||
There was a problem hiding this comment.
I think FROM mono:latest would be more explicit, although I'm always hesitant to use "latest" for anything. How about FROM mono:6.8, which would pick up 6.8* according to https://hub.docker.com/_/mono/
I don't think that a multi-stage build is required at all now, since both this Dockerfile and the upstream mono image are both Debian Stretch?
|
@rfay Thanks for those excellent points. I've given it another pass. Let me know what you think :) |
|
@TheCakeIsNaOH Thanks for the other PR. I'll close this in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18