-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null safety support #60
Conversation
@LinusU does this look good to you and are you willing to merge the PR? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've tested this branch with the oauth2_client library. Found no bugs so far.
1 month past, still not merged, is anything blocking it? @LinusU |
It seems that the author doesn't have interest in maintaining this project anymore as he is working on various other things. @LinusU I would happily help maintaining this project if you need help, i.e. adding me as collaborator. Many users need this library for their application to be updated appropriately. |
@LinusU I know you are probably very busy 😌 |
Great work @nonameden and thanks to @LinusU for maintaining this awesome project. Let's merge this soon! |
Thanks for migrating this! I would also love it if @LinusU could merge the changes. Thanks for the awesome package! |
I also need the null safety. Is it maybe an idea for @okrad to fork this? Especially as it is closely linked to his oauth client package and then we can have null safety in our apps? |
Migration guide: This version drops support for Flutter 1.x, please upgrade to Flutter 2 for continued support.
Migration guide: This version drops support for Flutter 1.x, please upgrade to Flutter 2 for continued support.
Sorry for the delay everyone! Fixed in 🚢 0.3.0 / 2021-04-06 |
Thanks @LinusU ! |
Thank you @LinusU!!! |
This reverts commit b0aa45d
Migrated package to support Null safety, following guide: https://dart.dev/null-safety/migration-guide
Linked issue: #59