Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety support #60

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Null safety support #60

merged 4 commits into from
Apr 6, 2021

Conversation

nonameden
Copy link
Contributor

Migrated package to support Null safety, following guide: https://dart.dev/null-safety/migration-guide

Linked issue: #59

pubspec.yaml Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@nonameden nonameden requested a review from LinusU March 3, 2021 19:40
@IchordeDionysos
Copy link

@LinusU does this look good to you and are you willing to merge the PR? :)

@phess101 phess101 mentioned this pull request Mar 18, 2021
Copy link

@jonasfranz jonasfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've tested this branch with the oauth2_client library. Found no bugs so far.

@junying1 junying1 mentioned this pull request Mar 26, 2021
@nonameden
Copy link
Contributor Author

1 month past, still not merged, is anything blocking it? @LinusU

@ThexXTURBOXx
Copy link
Contributor

ThexXTURBOXx commented Mar 27, 2021

It seems that the author doesn't have interest in maintaining this project anymore as he is working on various other things.

@LinusU I would happily help maintaining this project if you need help, i.e. adding me as collaborator. Many users need this library for their application to be updated appropriately.
If you want, just reach out to me and we can dicuss this further.

@IchordeDionysos
Copy link

@LinusU I know you are probably very busy 😌
Because of that, I think we all would appreciate it even more if you could take a look at this PR and release a null-safe version to pub.dev. 😍

@okrad
Copy link

okrad commented Mar 31, 2021

I second that... The lack of null safety support of this library is what prevents oauth2_client to be considered fully null safe.
@LinusU, I would really appreciate if you could merge this PR (and #42!). I would gladly help in any way.

@albertpurnama albertpurnama mentioned this pull request Apr 1, 2021
1 task
@albertpurnama
Copy link

Great work @nonameden and thanks to @LinusU for maintaining this awesome project.

Let's merge this soon!

@EthanShoeDev
Copy link

Thanks for migrating this! I would also love it if @LinusU could merge the changes. Thanks for the awesome package!

@chrislaurie-io
Copy link

I also need the null safety. Is it maybe an idea for @okrad to fork this? Especially as it is closely linked to his oauth client package and then we can have null safety in our apps?

pubspec.lock Outdated Show resolved Hide resolved
@LinusU LinusU merged commit c6c620e into LinusU:master Apr 6, 2021
LinusU pushed a commit that referenced this pull request Apr 6, 2021
Migration guide:

This version drops support for Flutter 1.x, please upgrade to Flutter 2 for continued support.
LinusU pushed a commit that referenced this pull request Apr 6, 2021
Migration guide:

This version drops support for Flutter 1.x, please upgrade to Flutter 2 for continued support.
@LinusU
Copy link
Owner

LinusU commented Apr 6, 2021

Sorry for the delay everyone!

Fixed in 🚢 0.3.0 / 2021-04-06

@albertpurnama
Copy link

Thanks @LinusU !

@okrad
Copy link

okrad commented Apr 6, 2021

Thank you @LinusU!!!

junying1 added a commit to junying1/flutter_web_auth that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants