Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wormhole.close force=true and from=undefined #216

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

nekuz0r
Copy link
Contributor

@nekuz0r nekuz0r commented May 6, 2019

According to the documentation, the parameter from is optional when force = true.

https://portal-vue.linusb.org/api/wormhole.html#close

There is three locations of this in the documentation

First in the parameters table, from is marked as not required.

Name of the Portal that the content was created with. Can be left out if the force flag is set

Secondly in this sentence:

Why do you have to provide the from name (or use force)?

And then in the example (variation with force)

// Variation with `force`
Wormhole.close({
    to: 'destination',
}, true)

@LinusBorg LinusBorg self-requested a review May 6, 2019 21:38
Copy link
Owner

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@LinusBorg LinusBorg merged commit b8491f8 into LinusBorg:develop Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants