Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.0 - new template and new PDF settings #35

Merged
merged 8 commits into from
Nov 1, 2023
Merged

1.3.0 - new template and new PDF settings #35

merged 8 commits into from
Nov 1, 2023

Conversation

brunoferreiralkn
Copy link
Contributor

@brunoferreiralkn brunoferreiralkn commented Oct 31, 2023 •
edited
Loading

Changelog

  • Add new template with QR Code left-aligned

  • Add new configuration to...

Check

  • Update hardcoded version
  • Update README with notes
  • Update CHANGELOG

@brunoferreiralkn brunoferreiralkn added the enhancement New feature or request label Oct 31, 2023
@brunoferreiralkn brunoferreiralkn self-assigned this Oct 31, 2023
@brunoferreiralkn brunoferreiralkn changed the title 1.3.0 - feat(pdf): adjust client name and e-mail not showing, add new templat… 1.3.0 - feat(pdf): adjust client name and e-mail not showing, add new template left-aligned Oct 31, 2023
This was linked to issues Nov 1, 2023
Nome e email não aparece na fatura #31
Closed
Rodapé padrão #33
Closed
campo customizado para inserir dados do remetente pela fatura #34
Closed
@brunoferreiralkn brunoferreiralkn linked an issue Nov 1, 2023 that may be closed by this pull request
Campo customizado para inserir antes do link de pagamento #32
Closed
@brunoferreiralkn brunoferreiralkn changed the title 1.3.0 - feat(pdf): adjust client name and e-mail not showing, add new template left-aligned 1.3.0 - new template and new PDF settings Nov 1, 2023
@FabricioQueirozLkn FabricioQueirozLkn self-requested a review November 1, 2023 19:05
@brunoferreiralkn brunoferreiralkn removed the request for review from emanuellopess November 1, 2023 19:15
FabricioQueirozLkn
FabricioQueirozLkn approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@FabricioQueirozLkn FabricioQueirozLkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If has been tested, it is approved.

@brunoferreiralkn brunoferreiralkn merged commit 773d399 into main Nov 1, 2023
@emanuellopess
Copy link
Contributor

@brunoferreiralkn Atenção, o plugin está fora das normativas do WordPress, não se pode usar curl nem se pode usar echo sem escapar o atributo:

  • Necessário substituir echo por esc_attr_e ou esc_html_e dependendo do contexto;
  • Necessário substituir curl por wp_remote_request

Não podemos nos desviar das normativas do WordPress pois nosso plugin pode ser reprovado e excluído da loja caso não sigamos a risca as normativas! Issue aberta, caso haja dúvidas pode me chamar. Issue aberta #36

@brunoferreiralkn brunoferreiralkn mentioned this pull request Nov 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabricioQueirozLkn FabricioQueirozLkn FabricioQueirozLkn approved these changes

Assignees

@brunoferreiralkn brunoferreiralkn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@brunoferreiralkn @emanuellopess @FabricioQueirozLkn