Check new version in individual coroutine scope and IO context

LinZong · Dec 30, 2024 · 963dc40 · 963dc40
1 parent 4e71604
commit 963dc40
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/src/main/java/moe/nemesiss/hostman/HostmanActivity.kt b/app/src/main/java/moe/nemesiss/hostman/HostmanActivity.kt
@@ -238,7 +238,10 @@ class HostmanActivity : ComponentActivity(), ServiceConnection {
         lifecycleScope.launch {
             lifecycle.repeatOnLifecycle(Lifecycle.State.STARTED) {
 
-                checkUpdateModel.checkNewVersionAvailable()
+                // Check new version in individual coroutine scope.
+                lifecycleScope.launch {
+                    checkUpdateModel.checkNewVersionAvailable()
+                }
 
                 ShizukuStateModel
                     .state

diff --git a/app/src/main/java/moe/nemesiss/hostman/service/CheckUpdateService.kt b/app/src/main/java/moe/nemesiss/hostman/service/CheckUpdateService.kt
@@ -4,6 +4,8 @@ import com.alibaba.fastjson2.to
 import com.alibaba.fastjson2.toJSONString
 import io.ktor.client.request.*
 import io.ktor.client.statement.*
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.withContext
 import moe.nemesiss.hostman.BuildConfig
 import moe.nemesiss.hostman.boost.EasyDebug
 import moe.nemesiss.hostman.model.*
@@ -34,8 +36,9 @@ object CheckUpdateService {
     }
 
     suspend fun checkNewVersionAvailable(): CheckVersionResult {
+
         try {
-            val latestVersion = getLatestAppVersion() ?: return NoNewVersionResult
+            val latestVersion = withContext(Dispatchers.IO) { getLatestAppVersion() } ?: return NoNewVersionResult
             val currentVersion = BuildConfig.VERSION_NAME.replace(".debug", "")
             if (latestVersion > AppVersion(currentVersion)) {
                 EasyDebug.info(TAG) { "New version available: $latestVersion, current version: $currentVersion" }