Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log_path directory creation #8

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

gfarmerfr
Copy link
Contributor

Je suppose que c’était ce qui était voulu à la base ?

@LimeDrive LimeDrive changed the base branch from master to dev June 11, 2024 19:53
@LimeDrive
Copy link
Owner

LimeDrive commented Jun 11, 2024

Yes encore une coquille 👍 ^^
Pas vraiment d'incidence vu que c'est déjà géré par loguru et sqlachemy.

Il y a aussi le nom de fichier dont j'ai besoin pour la création à virée donc :
Je te laisse commit sur la PR pour mettre directement avant de la poussé sur la branche dev.

Copy link
Owner

@LimeDrive LimeDrive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import os

...

directories = ["/app/config", os.path.dirname(settings.db_path), os.path.dirname(settings.log_path)]
...

@gfarmerfr gfarmerfr requested a review from LimeDrive June 11, 2024 21:46
Copy link
Owner

@LimeDrive LimeDrive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gfarmerfr
Copy link
Contributor Author

Done. C'est un peu plus propre en effet. makedirs ignore de toute manière le fichier final et crée l'arbo de manière recursive donc au final c'est juste esthétique.

@LimeDrive LimeDrive merged commit 8a12f71 into LimeDrive:dev Jun 11, 2024
@LimeDrive
Copy link
Owner

Yes clairement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants