Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go, hedera-sdk, go-ethereum versions #911

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

Coiling-Dragon
Copy link
Collaborator

Detailed description:

Which issue(s) this PR fixes:
Fixes some issues with failing grpc calls, mainly due to outdated hedera sdk.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #911 (d306be2) into main (b96b334) will decrease coverage by 0.08%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   64.29%   64.21%   -0.08%     
==========================================
  Files          86       86              
  Lines        6716     6716              
==========================================
- Hits         4318     4313       -5     
- Misses       2184     2188       +4     
- Partials      214      215       +1     
Flag Coverage Δ
unittests 64.21% <72.72%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/helper/http/encode.go 70.00% <100.00%> (ø)
config/config.go 42.42% <100.00%> (ø)
config/loggcp.go 67.85% <ø> (ø)
app/clients/hedera/mirror-node/client.go 70.04% <66.66%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Stanislav Viyachev <[email protected]>
@Coiling-Dragon Coiling-Dragon merged commit 4f8f07f into main Nov 21, 2023
6 of 7 checks passed
@Coiling-Dragon Coiling-Dragon deleted the chore/update-hedera-sdk branch November 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants