Fixed a memory leak in the Retry functionality for EVM clients #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 64.15% 64.29% +0.14%
==========================================
Files 86 86
Lines 6731 6716 -15
==========================================
Hits 4318 4318
+ Misses 2199 2184 -15
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asenslime
reviewed
Aug 15, 2023
asenslime
previously approved these changes
Aug 15, 2023
rokn
force-pushed
the
fix/retry-memory-leak
branch
from
46851a9
to
9af038f
Compare
Coiling-Dragon
previously approved these changes
Aug 18, 2023
Signed-off-by: Antonio Mindov <[email protected]>
rokn
force-pushed
the
fix/retry-memory-leak
branch
from
9af038f
to
0d0c186
Compare
Coiling-Dragon
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
The retry loop was leaking go routine from the flow which was not finished(either the timeout or the
executionFunctionbecause when one finished the other couldn't send a message on it's channel.The solution is to just use a context with a timeout and leave the handling to the user which works perfectly in our case as everywhere we are using this we are already using a context.
Special notes for your reviewer:
Checklist