Docs/integration #240
Merged
Docs/integration #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: failfmi <[email protected]>
Signed-off-by: failfmi <[email protected]>
Signed-off-by: failfmi <[email protected]>
Signed-off-by: failfmi <[email protected]>
# Conflicts: # app/services/transfers/service.go # e2e/e2e_test.go # e2e/setup/config.go
Signed-off-by: radtonev <[email protected]>
Daniel-K-Ivanov
requested changes
May 18, 2021
docs/integration.md
Outdated
| # Integration with Hedera <-> EVM-chain bridge | ||
| The Bridge provides users with functionality to transfer HBAR or HTS tokens from Hedera to EVM-based chain or Wrapped HBAR and Wrapped Tokens from EVM-based chain to Hedera. The Bridge is operated by registered validators that provide signatures for every requested transfer. The transfer is processed when the majority of validators verify the transfer (supermajority). | ||
|
|
||
| ## 1. Hedera -> EVM-chain |
There was a problem hiding this comment.
I think that this document should be focused on what exactly should be done by the integrator step-by-step.
So it will be better if we do not have 1.1 How it works, but rather ->
- Step 1. Initiate transfer of HBAR/HTS
- Step 2. Wait for confirmation
- Step 3. Claim Asset on EVM chain
The goal would be for someone to read the document and know what he has to do in order to integrate
Signed-off-by: radtonev <[email protected]>
Signed-off-by: radtonev <[email protected]>
Signed-off-by: radtonev <[email protected]>
Signed-off-by: Daniel Ivanov <[email protected]>
Signed-off-by: Daniel Ivanov <[email protected]>
Signed-off-by: Daniel Ivanov <[email protected]>
Daniel-K-Ivanov
approved these changes
May 19, 2021
svetlio8
pushed a commit
that referenced
this pull request
Nov 18, 2021
* feat: sign and store router address Signed-off-by: failfmi <[email protected]> * fix: transfer data check Signed-off-by: failfmi <[email protected]> * fix: check if fee exists Signed-off-by: failfmi <[email protected]> * e2e: add router address to expected transfer Signed-off-by: failfmi <[email protected]> * Draft documentation Signed-off-by: radtonev <[email protected]> * Draft documentation Signed-off-by: radtonev <[email protected]> * Draft documentation Signed-off-by: radtonev <[email protected]> * Draft documentation Signed-off-by: radtonev <[email protected]> * Update integration.md * add feedback on the integration docs Signed-off-by: Daniel Ivanov <[email protected]> * resolve TODOs Signed-off-by: Daniel Ivanov <[email protected]> * add docs to read me Signed-off-by: Daniel Ivanov <[email protected]> Co-authored-by: failfmi <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Added documentation on how to integrate with the bridge
Special notes for your reviewer:
Checklist