Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP and WS RPC APIs to listen on the same socket #133

Merged
merged 9 commits into from
Aug 17, 2023
Merged

HTTP and WS RPC APIs to listen on the same socket #133

merged 9 commits into from
Aug 17, 2023

Conversation

ablax
Copy link
Member

@ablax ablax commented Aug 17, 2023

  • Websocket configuration to differentiate http and ws request
  • Remove HttpRpc

Closes #132

vikinatora
vikinatora requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename everything that is "ws" to "rpc". For example WebSocketConfig should be RpcConfig,

@ablax ablax requested a review from vikinatora August 17, 2023 08:43
@ablax ablax merged commit 56a0b88 into dev Aug 17, 2023
1 check passed
@ablax ablax deleted the #132-http-and-ws-on-same-port branch August 17, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikinatora vikinatora vikinatora approved these changes

@Jess25051980 Jess25051980 Jess25051980 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP and WS RPC APIs to listen on the same socket
3 participants
@ablax @vikinatora @Jess25051980