Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zk-js: utils - fetchNullifierAccountInfo - fixes getBalance #141

Merged
merged 2 commits into from
Jun 5, 2023
Merged

zk-js: utils - fetchNullifierAccountInfo - fixes getBalance #141

merged 2 commits into from
Jun 5, 2023
+1 −1

Conversation

ananas-block
Copy link
Contributor

Problem:

  • balance fetch does not categorize spent utxos in all cases
  • ci tests fail and seem flaky

Solution:

  • force nullifier serialization during nullifier pubkey derivation to always be 32 bytes

@vadorovsky vadorovsky merged commit 6f72f67 into main Jun 5, 2023
@vadorovsky vadorovsky deleted the jorrit-fix-nullifier-flakeness branch June 5, 2023 19:53
vadorovsky pushed a commit to vadorovsky/light-protocol that referenced this pull request May 1, 2024
@ananas-block
zk-js: utils - fetchNullifierAccountInfo - fixes getBalance (Lightpro…
02588fc 
…tocol#141)

* zk-js: utils - fetchNullifierAccountInfo fixed nullifier pubkey derivation

* zk.js - fetchNullifierAccountInfo streamlined to buffer conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @vadorovsky