This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
Update PyPI release trigger #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rohitgr7 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=====================================
Coverage 74% 74%
=====================================
Files 63 63
Lines 1462 1462
=====================================
Hits 1086 1086
Misses 376 376 |
Utils were always automated, and PL for a while had not implemented the multi-package flow as it has been done since 1.8 |
Borda
approved these changes
Nov 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyPI release workflow wasn't triggered by the
releaseevent type as reported by @rohitgr7. The exact reason is still unknown, but it could be due totypes: [created]. This PR updates the trigger so that it all aligns across our repositories' settings.See the workflow file in our repo: https://github.com/Lightning-AI/lightning/blob/4750e221d1e7622bbf2d0e5b09e7136032e9c410/.github/workflows/release-pypi.yml#L8