Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Implement Masked Language Modeling (#77) #173

Merged
merged 1 commit into from
May 22, 2021
Merged

Implement Masked Language Modeling (#77) #173

merged 1 commit into from
May 22, 2021

Conversation

bzantium
Copy link
Contributor

  • Implement masked language modeling task
  • Add hydra config files
  • Add test code

@mergify mergify bot requested a review from Borda May 22, 2021 08:00
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @bzantium! the code is very clean as well, once the CI finishes, I'll merge :)

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #173 (b35f154) into master (02c064c) will decrease coverage by 15.42%.
The diff coverage is 82.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #173       +/-   ##
===========================================
- Coverage   84.60%   69.18%   -15.43%     
===========================================
  Files          66       70        +4     
  Lines        1397     1467       +70     
===========================================
- Hits         1182     1015      -167     
- Misses        215      452      +237     
Flag Coverage Δ
unittests 69.18% <82.85%> (-15.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sformers/task/nlp/masked_language_modeling/data.py 72.97% <72.97%> (ø)
...formers/task/nlp/masked_language_modeling/model.py 91.66% <91.66%> (ø)
...mers/task/nlp/masked_language_modeling/__init__.py 100.00% <100.00%> (ø)
...ormers/task/nlp/masked_language_modeling/config.py 100.00% <100.00%> (ø)
...ning_transformers/task/nlp/summarization/metric.py 27.58% <0.00%> (-72.42%) ⬇️
...transformers/task/nlp/token_classification/data.py 33.87% <0.00%> (-58.07%) ⬇️
...ing_transformers/task/nlp/multiple_choice/model.py 42.42% <0.00%> (-51.52%) ⬇️
...ransformers/task/nlp/token_classification/model.py 51.16% <0.00%> (-48.84%) ⬇️
...ing_transformers/task/nlp/multiple_choice/utils.py 52.38% <0.00%> (-47.62%) ⬇️
...ransformers/task/nlp/translation/datasets/wmt16.py 54.54% <0.00%> (-45.46%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c064c...b35f154. Read the comment docs.

@SeanNaren
Copy link
Contributor

Failing test is unrelated, should be fixed separately, so will merge!

@SeanNaren SeanNaren merged commit d075905 into Lightning-Universe:master May 22, 2021
@bzantium
Copy link
Contributor Author

bzantium commented May 22, 2021

Thank you so much! It's an honour to contribute to this great project :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants