Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Document object detector augmentations #776

Conversation

gianscarpe
Copy link
Contributor

@gianscarpe gianscarpe commented Sep 20, 2021

What does this PR do?

Fixes #488

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #776 (5a4afc2) into master (742fe2e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   89.62%   89.61%   -0.01%     
==========================================
  Files         213      213              
  Lines       11317    11309       -8     
==========================================
- Hits        10143    10135       -8     
  Misses       1174     1174              
Flag Coverage Δ
unittests 89.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 94.16% <100.00%> (ø)
flash/core/utilities/imports.py 90.69% <100.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742fe2e...5a4afc2. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 😃

@ethanwharris ethanwharris changed the title Issue488/document object detector Document object detector augmentations Sep 22, 2021
@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Sep 22, 2021
@gianscarpe
Copy link
Contributor Author

Awesome! LGTM smiley

Hi @ethanwharris ! I also added a couple of lines of documentation in object_detector. Think automatic documentation could improved simply by documenting the code more! :)

@ethanwharris ethanwharris merged commit ae525d9 into Lightning-Universe:master Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document ObjectDetectionData transforms
2 participants