Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

support list & callable transforms #693

Merged
merged 12 commits into from
Sep 2, 2021
Merged

support list & callable transforms #693

merged 12 commits into from
Sep 2, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Aug 25, 2021

What does this PR do?

Fixes #644

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #693 (d915bfb) into master (797ae9f) will increase coverage by 4.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   84.69%   89.38%   +4.69%     
==========================================
  Files         197      197              
  Lines       10512    10517       +5     
==========================================
+ Hits         8903     9401     +498     
+ Misses       1609     1116     -493     
Flag Coverage Δ
unittests 89.38% <100.00%> (+4.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.57% <ø> (ø)
flash/image/classification/data.py 94.11% <ø> (ø)
flash/core/data/process.py 87.55% <100.00%> (+0.26%) ⬆️
flash/text/seq2seq/translation/model.py 76.19% <0.00%> (+4.76%) ⬆️
flash/text/seq2seq/summarization/model.py 80.00% <0.00%> (+5.00%) ⬆️
flash/text/seq2seq/core/model.py 75.32% <0.00%> (+10.38%) ⬆️
flash/text/question_answering/finetuning.py 19.78% <0.00%> (+14.28%) ⬆️
flash/text/seq2seq/core/data.py 89.87% <0.00%> (+21.51%) ⬆️
flash/text/classification/model.py 92.30% <0.00%> (+25.00%) ⬆️
flash/text/seq2seq/core/metrics.py 99.07% <0.00%> (+25.00%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797ae9f...d915bfb. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😃 Can we get some tests?

@aniketmaurya
Copy link
Contributor Author

Awesome 😃 Can we get some tests?

sure I will add 😄

@aniketmaurya
Copy link
Contributor Author

aniketmaurya commented Aug 27, 2021

@ethanwharris I have added a test for _check_transforms. Let me know if there is an issue.

@aniketmaurya
Copy link
Contributor Author

aniketmaurya commented Aug 29, 2021

deepsource check has been running for a day 🤔

@akihironitta
Copy link
Contributor

deepsource check has been running for a day

It seems the check was done in a minute, but the status of the run hasn't been updated on GitHub somehow...

@aniketmaurya
Copy link
Contributor Author

deepsource check has been running for a day

It seems the check was done in a minute, but the status of the run hasn't been updated on GitHub somehow...

@ethanwharris could you rerun that check?

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris merged commit 4ebc45d into Lightning-Universe:master Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for a list of transforms rather than dict
3 participants