-
Notifications
You must be signed in to change notification settings - Fork 211
support list & callable transforms #693
support list & callable transforms #693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 84.69% 89.38% +4.69%
==========================================
Files 197 197
Lines 10512 10517 +5
==========================================
+ Hits 8903 9401 +498
+ Misses 1609 1116 -493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 😃 Can we get some tests?
sure I will add 😄 |
@ethanwharris I have added a test for |
|
It seems the check was done in a minute, but the status of the run hasn't been updated on GitHub somehow... |
@ethanwharris could you rerun that check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
Fixes #644
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃