Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

add API reference and tests #680

Merged
merged 23 commits into from
Aug 19, 2021
Merged

add API reference and tests #680

merged 23 commits into from
Aug 19, 2021

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Aug 19, 2021

What does this PR do?

Adds tests for optimizers and API references.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #680 (1b7c2c5) into master (8b27498) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         192      192           
  Lines        9905     9905           
=======================================
  Hits         8882     8882           
  Misses       1023     1023           
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/optimizers/lamb.py 34.28% <ø> (ø)
flash/core/optimizers/lars.py 49.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b27498...1b7c2c5. Read the comment docs.

@ananyahjha93 ananyahjha93 changed the title [wip] add API reference and tests add API reference and tests Aug 19, 2021
@ananyahjha93 ananyahjha93 enabled auto-merge (squash) August 19, 2021 06:22
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris disabled auto-merge August 19, 2021 09:37
@ethanwharris ethanwharris merged commit 152bfe1 into master Aug 19, 2021
@ethanwharris ethanwharris deleted the feature/optimizers branch August 19, 2021 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants