This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add community and governance #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
ananyahjha93,
Borda,
carmocca,
edenlightning,
justusschock,
kaushikb11 and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
===========================================
- Coverage 89.67% 66.02% -23.65%
===========================================
Files 192 192
Lines 9905 9905
===========================================
- Hits 8882 6540 -2342
- Misses 1023 3365 +2342
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Aug 18, 2021
Comment on lines
+8
to
+15
| - William Falcon (`williamFalcon <https://github.com/williamFalcon>`_) | ||
| - Thomas Chaton (`tchaton <https://github.com/tchaton>`_) | ||
| - Ethan Harris (`ethanwharris <https://github.com/ethanwharris>`_) | ||
| - Jirka Borovec (`Borda <https://github.com/Borda>`_) | ||
| - Kaushik Bokka (`kaushikb11 <https://github.com/kaushikb11>`_) | ||
| - Justus Schock (`justusschock <https://github.com/justusschock>`_) | ||
| - Carlos Mocholí (`carmocca <https://github.com/carmocca>`_) | ||
| - Sean Narenthiran (`SeanNaren <https://github.com/SeanNaren>`_) |
There was a problem hiding this comment.
this is a copy from PL, so are also all leads from PL leads in Flash?
There was a problem hiding this comment.
Not quite copied, adapted 😃 These are all the PL leads who have also made contributions to flash
There was a problem hiding this comment.
yes, but for example I not feel like lead for Flash, rather be just core :P
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃