Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update codeowners #668

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Update codeowners #668

merged 4 commits into from
Aug 16, 2021

Conversation

ananyahjha93
Copy link
Contributor

What does this PR do?

Add to list of codeowners

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #668 (b8d25f4) into master (0e8c0ce) will increase coverage by 26.71%.
The diff coverage is n/a.

❗ Current head b8d25f4 differs from pull request most recent head 9e6da35. Consider uploading reports for the commit 9e6da35 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #668       +/-   ##
===========================================
+ Coverage   63.30%   90.01%   +26.71%     
===========================================
  Files         185      185               
  Lines        9663     9663               
===========================================
+ Hits         6117     8698     +2581     
+ Misses       3546      965     -2581     
Flag Coverage Δ
unittests 90.01% <ø> (+26.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/lightning_cli.py 98.57% <0.00%> (+0.95%) ⬆️
flash/core/trainer.py 86.81% <0.00%> (+1.09%) ⬆️
flash/core/data/properties.py 100.00% <0.00%> (+1.31%) ⬆️
flash/core/data/data_pipeline.py 94.38% <0.00%> (+1.32%) ⬆️
flash/core/data/process.py 87.28% <0.00%> (+1.69%) ⬆️
flash/core/data/callback.py 100.00% <0.00%> (+2.66%) ⬆️
flash/image/instance_segmentation/data.py 71.87% <0.00%> (+3.12%) ⬆️
flash/core/data/splits.py 96.66% <0.00%> (+3.33%) ⬆️
flash/image/keypoint_detection/data.py 72.41% <0.00%> (+3.44%) ⬆️
flash/pointcloud/segmentation/open3d_ml/app.py 33.33% <0.00%> (+5.88%) ⬆️
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8c0ce...9e6da35. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris merged commit c40f384 into master Aug 16, 2021
@ethanwharris ethanwharris deleted the update/codeowners branch August 16, 2021 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants