This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
ImageEmbedder Docs: Fix print and remove embedding_dim usage #665
Merged
ananyahjha93
merged 6 commits into
Lightning-Universe:master
from
tszumowski:docs/fix_embedding_print
Aug 16, 2021
Merged
ImageEmbedder Docs: Fix print and remove embedding_dim usage #665
ananyahjha93
merged 6 commits into
Lightning-Universe:master
from
tszumowski:docs/fix_embedding_print
Aug 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tszumowski
requested review from
Borda,
carmocca,
edenlightning,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
August 16, 2021 16:08
Test: Validate image_embedder.py Example
The last line shows it still runs end to end. |
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 87.98% 89.36% +1.37%
==========================================
Files 185 185
Lines 9663 9663
==========================================
+ Hits 8502 8635 +133
+ Misses 1161 1028 -133
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Test: Validate README ExampleExecuted README code:
Output:
Last line shows it working.
|
ananyahjha93
approved these changes
Aug 16, 2021
Borda
added
bug / fix
Something isn't working
documentation
Improvements or additions to documentation
labels
Aug 16, 2021
Borda
approved these changes
Aug 16, 2021
ethanwharris
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 😃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
embedding_dim
usage in examples since it shouldn't be used unless fine tuning is includedFixes #656
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃