Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

pre-commit: pyupgrade #658

Merged
merged 3 commits into from
Aug 15, 2021
Merged

pre-commit: pyupgrade #658

merged 3 commits into from
Aug 15, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 14, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Aug 14, 2021
@Borda Borda enabled auto-merge (squash) August 14, 2021 09:04
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #658 (5e07281) into master (5f11ebc) will decrease coverage by 0.00%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         173      173              
  Lines        9235     9232       -3     
==========================================
- Hits         8366     8363       -3     
  Misses        869      869              
Flag Coverage Δ
unittests 90.58% <88.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_source.py 94.61% <0.00%> (ø)
flash/core/serve/dag/rewrite.py 94.96% <0.00%> (ø)
flash/setup_tools.py 61.29% <0.00%> (ø)
flash/core/data/transforms.py 100.00% <100.00%> (ø)
flash/core/serve/component.py 94.33% <100.00%> (ø)
flash/core/serve/dag/task.py 97.84% <100.00%> (-0.04%) ⬇️
flash/core/serve/types/label.py 100.00% <100.00%> (ø)
flash/core/serve/types/repeated.py 97.14% <100.00%> (ø)
flash/image/classification/backbones/resnet.py 90.85% <100.00%> (ø)
flash/image/detection/serialization.py 94.23% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f11ebc...5e07281. Read the comment docs.

@Borda Borda disabled auto-merge August 15, 2021 21:45
@Borda Borda merged commit 9061d4b into master Aug 15, 2021
@Borda Borda deleted the pyupgrade branch August 15, 2021 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants