Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

use Black #634

Merged
merged 5 commits into from
Aug 5, 2021
Merged

use Black #634

merged 5 commits into from
Aug 5, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 5, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda marked this pull request as ready for review August 5, 2021 08:24
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #634 (5a8192a) into master (8e42d39) will increase coverage by 0.00%.
The diff coverage is 84.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   90.62%   90.63%           
=======================================
  Files         173      173           
  Lines        9183     9182    -1     
=======================================
  Hits         8322     8322           
+ Misses        861      860    -1     
Flag Coverage Δ
gpu ?
pytest ?
unittests 90.63% <84.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/__init__.py 89.47% <ø> (ø)
flash/audio/classification/cli.py 100.00% <ø> (ø)
flash/audio/classification/data.py 93.75% <ø> (ø)
flash/audio/speech_recognition/cli.py 100.00% <ø> (ø)
flash/core/classification.py 96.52% <ø> (ø)
flash/core/finetuning.py 88.88% <ø> (ø)
flash/core/schedulers.py 100.00% <ø> (ø)
flash/core/serve/flash_components.py 90.74% <ø> (ø)
flash/core/serve/types/label.py 100.00% <ø> (ø)
flash/core/serve/types/table.py 100.00% <ø> (ø)
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e42d39...5a8192a. Read the comment docs.

@Borda Borda merged commit 4ebb087 into master Aug 5, 2021
@Borda Borda deleted the black branch August 5, 2021 13:49
@Borda Borda mentioned this pull request Aug 5, 2021
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants