Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fixes for Wav2Vec example #609

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Fixes for Wav2Vec example #609

merged 2 commits into from
Jul 21, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jul 21, 2021

What does this PR do?

limiting batches shouldn't be happening!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug / fix Something isn't working label Jul 21, 2021
@SeanNaren SeanNaren self-assigned this Jul 21, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #609 (e3203b2) into master (08b56dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files         149      149           
  Lines        8457     8457           
=======================================
  Hits         7610     7610           
  Misses        847      847           
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b56dd...e3203b2. Read the comment docs.

@ethanwharris ethanwharris merged commit 0f6bb7e into master Jul 21, 2021
@ethanwharris ethanwharris deleted the fix/example branch July 21, 2021 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants