Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Temporary fix for RTD build #605

Merged
merged 38 commits into from
Jul 23, 2021
Merged

Temporary fix for RTD build #605

merged 38 commits into from
Jul 23, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 19, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #605 (f9b2836) into master (0f6bb7e) will decrease coverage by 0.00%.
The diff coverage is 68.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   89.98%   89.98%   -0.01%     
==========================================
  Files         149      149              
  Lines        8457     8456       -1     
==========================================
- Hits         7610     7609       -1     
  Misses        847      847              
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.98% <68.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/pointcloud/segmentation/open3d_ml/app.py 33.33% <27.50%> (+2.72%) ⬆️
...tcloud/segmentation/open3d_ml/sequences_dataset.py 82.56% <80.80%> (ø)
flash/audio/speech_recognition/model.py 97.14% <100.00%> (ø)
flash/core/utilities/imports.py 91.50% <100.00%> (ø)
flash/pointcloud/detection/data.py 82.85% <100.00%> (-0.48%) ⬇️
flash/pointcloud/detection/model.py 82.81% <100.00%> (ø)
...ash/pointcloud/detection/open3d_ml/data_sources.py 82.90% <100.00%> (ø)
flash/pointcloud/segmentation/data.py 78.94% <100.00%> (-1.06%) ⬇️
flash/pointcloud/segmentation/model.py 76.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6bb7e...f9b2836. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jul 23, 2021

Hello @ethanwharris! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-23 10:51:43 UTC

@ethanwharris ethanwharris marked this pull request as ready for review July 23, 2021 10:53
@ethanwharris ethanwharris changed the title Debugging docs build Temporary fix for RTD build Jul 23, 2021
@ethanwharris ethanwharris merged commit ffe31b5 into master Jul 23, 2021
@ethanwharris ethanwharris deleted the docs_build2 branch July 23, 2021 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants