Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Move big dependencies out to *_extras requirements and treat them as fully optional #583

Merged
merged 20 commits into from
Jul 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 13, 2021

What does this PR do?

Fixes #451

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #583 (b165091) into master (adfa434) will increase coverage by 0.25%.
The diff coverage is 89.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   91.42%   91.67%   +0.25%     
==========================================
  Files         117      117              
  Lines        7204     7210       +6     
==========================================
+ Hits         6586     6610      +24     
+ Misses        618      600      -18     
Flag Coverage Δ
unittests 91.67% <89.39%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/serialization.py 76.47% <41.66%> (+2.62%) ⬆️
flash/core/classification.py 96.52% <100.00%> (+0.66%) ⬆️
flash/core/data/data_module.py 93.93% <100.00%> (+0.40%) ⬆️
flash/core/data/data_source.py 95.28% <100.00%> (+0.97%) ⬆️
flash/core/integrations/fiftyone/utils.py 37.93% <100.00%> (+4.59%) ⬆️
flash/core/model.py 86.52% <100.00%> (ø)
flash/core/serve/component.py 94.33% <100.00%> (ø)
flash/core/serve/core.py 87.87% <100.00%> (ø)
flash/core/utilities/imports.py 90.21% <100.00%> (+0.44%) ⬆️
flash/image/classification/data.py 89.33% <100.00%> (-5.34%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfa434...b165091. Read the comment docs.

@ethanwharris ethanwharris marked this pull request as ready for review July 13, 2021 21:17
flash/core/classification.py Show resolved Hide resolved
@ethanwharris ethanwharris merged commit 7237a9f into master Jul 14, 2021
@ethanwharris ethanwharris deleted the feature/image_extras branch July 14, 2021 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing [image] extras is not sufficient on Python 3.6?
2 participants