Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[WIP] Added TabularRegressionPreprocess extended TabularPreprocess #580

Conversation

sumanmichael
Copy link
Contributor

What does this PR do?

Created TabularRegressionPreprocess stub

TabularRegressionPreprocess has a lot common with TabularPreprocessin tabular/classification/data.py.
Here's what I did.

  • created TabularClassificationPreprocess in new tabular/classification/data.py & TabularRegressionPreprocess in new tabular/regression/data.py extending the TabularPreprocess in tabular/data.py by fixing the respective is_regression bool param.
  • changed required __ init __.py files

Fixes #528

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@sumanmichael sumanmichael changed the title Feature/tabular regression preprocess [WIP] Added TabularRegressionPreprocess extended TabularPreprocess Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #580 (de6c4b6) into master (27cc06d) will decrease coverage by 0.03%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   91.41%   91.38%   -0.04%     
==========================================
  Files         117      117              
  Lines        7200     7219      +19     
==========================================
+ Hits         6582     6597      +15     
- Misses        618      622       +4     
Flag Coverage Δ
unittests 91.38% <84.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/data.py 83.33% <80.00%> (-16.67%) ⬇️
flash/tabular/regression/data.py 84.61% <81.81%> (-15.39%) ⬇️
flash/tabular/__init__.py 100.00% <100.00%> (ø)
flash/tabular/classification/__init__.py 100.00% <100.00%> (ø)
flash/tabular/regression/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cc06d...de6c4b6. Read the comment docs.

@sumanmichael sumanmichael marked this pull request as draft July 14, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create TabularForecastingPreprocess stub
1 participant