Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Improve data docs #355

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Improve data docs #355

merged 11 commits into from
Jul 8, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jun 3, 2021

What does this PR do?

Description of the changes

  • Adds Deserializer
  • Includes minor fixes/improvements, e.g. links/formatting/...

Before submitting

  • [n/a] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the documentation Improvements or additions to documentation label Jun 3, 2021
@akihironitta akihironitta self-assigned this Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #355 (aa3644d) into master (8077f7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         112      112           
  Lines        7127     7127           
=======================================
  Hits         6508     6508           
  Misses        619      619           
Flag Coverage Δ
unittests 91.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/process.py 86.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8077f7b...aa3644d. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta Great work here 😃 shall we merge this one so you don't get out of sync in #555?

@akihironitta akihironitta marked this pull request as ready for review July 8, 2021 08:33
@akihironitta
Copy link
Contributor Author

@ethanwharris Sure, sounds good!

@akihironitta akihironitta changed the title [WIP] Improve data docs Improve data docs Jul 8, 2021
@ethanwharris ethanwharris merged commit 74dbee8 into master Jul 8, 2021
@ethanwharris ethanwharris deleted the docs/data branch July 8, 2021 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants