Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

remove functional call from sigmoid and softmax #255

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

edgarriba
Copy link
Contributor

What does this PR do?

switch calls to sigmoid and softmax from nn.functional to top level torch api

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aribornstein
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #255 (d2a6c30) into master (b275d8b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          59       59           
  Lines        3123     3123           
=======================================
  Hits         2729     2729           
  Misses        394      394           
Flag Coverage Δ
unittests 87.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/classification.py 92.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b275d8b...d2a6c30. Read the comment docs.

@edgarriba edgarriba linked an issue Apr 29, 2021 that may be closed by this pull request
@kaushikb11 kaushikb11 merged commit 2b39eae into master Apr 29, 2021
@kaushikb11 kaushikb11 deleted the edgarriba-patch-1 branch April 29, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nn.functional.sigmoid is deprecated. Use torch.sigmoid instead
4 participants